feat: add github action for macos build
- https://github.com/Homebrew/homebrew-core/pull/171238
still
/Users/runner/work/HTTPing/HTTPing/error.c:3:10: fatal error: 'libintl.h' file not found
#include <libintl.h>
^~~~~~~~~~~
1 error generated.
Hi Rui,
Thanks! Please note that libintl.h/gettext is now optional. See README.md for details for the v3.7a tag.
On Sun, May 12, 2024 at 10:07:10PM -0700, Rui Chen wrote:
still
/Users/runner/work/HTTPing/HTTPing/error.c:3:10: fatal error: 'libintl.h' file not found #include <libintl.h> ^~~~~~~~~~~ 1 error generated.
Ehm, something went wrong I believe. It contains all kinds of patches not related, right?
Ehm, something went wrong I believe. It contains all kinds of patches not related, right?
no, I think it is okay, what do you refer to?
Github says:
Github says:
oh yeah, all the commits are in the fork, that is why it said so.
any way, the pr should be good now. :)
The problem with your branch is that you've merged the origin/master branch instead of making git rebase origin/master. I'm not a git guru, so I don't know exactly how to reset this branch. But what I suggest, is the following:
This branch should have only two commits:
- Fix for FASTOPEN feature on MacOS
- GitHub Action file for MacOS
Another PR for adding *.mo files to the .gitignore.
An additional PR for Debug option. Though, I'm still not sure that we need this as this option will be set during the cmake -B build command.
gonna split the stuff in this PR out. thanks!
