devmoji icon indicating copy to clipboard operation
devmoji copied to clipboard

Adds TypeScript support for configuration file

Open AlvaroIsrael opened this issue 2 years ago • 5 comments

Description

Hello, I love adding emojis to my commits and recently I found this repository to be a good tool to automate this process to me and also other devs of projects I work on. The thing is, I like TypeScript and have a tendency of not allowing any .js files in projects I work with. The fact this project only supported configuration file in .js format kind of bothered me a little, so I decided to add typescript support for the configuration file devmoji.config.ts. The PR is here: https://github.com/folke/devmoji/pull/220

Type of change

  • [X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I ran all the test suits with both yarn test and yarn test:cov and provided a new test to the new typescript configuration file.

  • [X] load typescript from config file

image

(Also tried to improve coverage a bit by adding a test for a uncovered scenario config file does not exist).

Checklist:

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] My changes generate no new warnings
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

AlvaroIsrael avatar Oct 24 '23 04:10 AlvaroIsrael

Hello @folke, could you please take a look here when you can?

AlvaroIsrael avatar Oct 31 '23 23:10 AlvaroIsrael