flytestdlib icon indicating copy to clipboard operation
flytestdlib copied to clipboard

[wip] Move db logic to stdlib

Open wild-endeavor opened this issue 3 years ago • 1 comments

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • [ ] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA OR https://github.com/flyteorg/flyte/issues/

wild-endeavor avatar Dec 03 '22 02:12 wild-endeavor

Codecov Report

Merging #147 (f234638) into master (0dbe3c2) will decrease coverage by 1.02%. The diff coverage is 31.25%.

:exclamation: Current head f234638 differs from pull request most recent head 90331d1. Consider uploading reports for the commit 90331d1 to get more accurate results

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   68.16%   67.15%   -1.02%     
==========================================
  Files          69       71       +2     
  Lines        4081     4189     +108     
==========================================
+ Hits         2782     2813      +31     
- Misses       1141     1216      +75     
- Partials      158      160       +2     
Flag Coverage Δ
unittests 67.15% <31.25%> (-1.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/config.go 93.93% <0.00%> (-6.07%) :arrow_down:
database/mysql.go 27.08% <27.08%> (ø)
database/postgres.go 35.48% <35.48%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Dec 03 '22 02:12 codecov[bot]