flytestdlib
flytestdlib copied to clipboard
Adding utils for signal ID context
TL;DR
With the additional of the signal service in FlyteAdmin we may want to track metrics on a per-signal basis. To do this we need to set the signal ID on the context.
Type
- [ ] Bug Fix
- [x] Feature
- [ ] Plugin
Are all requirements met?
- [x] Code completed
- [x] Smoke tested
- [x] Unit tests added
- [x] Code documentation added
- [ ] Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
https://github.com/flyteorg/flyte/issues/208
Follow-up issue
NA
Codecov Report
Merging #137 (6368b4f) into master (1279ea2) will increase coverage by
0.04%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 68.75% 68.79% +0.04%
==========================================
Files 69 69
Lines 3405 3407 +2
==========================================
+ Hits 2341 2344 +3
+ Misses 905 904 -1
Partials 159 159
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 67.66% <100.00%> (+0.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| contextutils/context.go | 82.08% <100.00%> (+0.55%) |
:arrow_up: |
| sets/generic_set.go | 100.00% <0.00%> (+1.08%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 1279ea2...6368b4f. Read the comment docs.