Additional catalog client functionality for cache eviction
TL;DR
Added extra methods for accessing and removing artifact data to catalog client.
Type
- [ ] Bug Fix
- [X] Feature
- [ ] Plugin
Are all requirements met?
- [X] Code completed
- [X] Smoke tested
- [ ] Unit tests added
- [X] Code documentation added
- [ ] Any pending items have an associated Issue
Complete description
The new ByArtifactTag methods were added to allow for easier access to reservations from flyteadmin (which retrieves the artifact tag from its stored metadata without having to access the stored artifact to generate a catalog.Key).
Additional functionality for deleting artifacts has been added as well.
Tracking Issue
https://github.com/flyteorg/flyte/issues/2867
Follow-up issue
NA
Codecov Report
Merging #301 (79e9a15) into master (8efeda7) will increase coverage by
1.18%. The diff coverage isn/a.
:exclamation: Current head 79e9a15 differs from pull request most recent head bda210e. Consider uploading reports for the commit bda210e to get more accurate results
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 62.35% 63.53% +1.18%
==========================================
Files 147 145 -2
Lines 11809 9334 -2475
==========================================
- Hits 7363 5930 -1433
+ Misses 3882 2859 -1023
+ Partials 564 545 -19
| Flag | Coverage Δ | |
|---|---|---|
| unittests | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| go/tasks/pluginmachinery/catalog/client.go | 87.50% <ø> (-0.60%) |
:arrow_down: |
| go/tasks/pluginmachinery/flytek8s/pod_helper.go | 79.13% <0.00%> (-4.94%) |
:arrow_down: |
| go/tasks/plugins/array/inputs.go | 83.33% <0.00%> (-4.91%) |
:arrow_down: |
| .../pluginmachinery/internal/webapi/plugin_context.go | 50.00% <0.00%> (-3.85%) |
:arrow_down: |
| go/tasks/plugins/k8s/sagemaker/plugin.go | 74.07% <0.00%> (-3.20%) |
:arrow_down: |
| go/tasks/plugins/array/core/state.go | 69.13% <0.00%> (-2.85%) |
:arrow_down: |
| go/tasks/plugins/hive/config/config.go | 33.33% <0.00%> (-2.39%) |
:arrow_down: |
| go/tasks/plugins/presto/config/config.go | 33.33% <0.00%> (-2.39%) |
:arrow_down: |
| go/tasks/plugins/array/core/metadata.go | 80.00% <0.00%> (-2.23%) |
:arrow_down: |
| go/tasks/pluginmachinery/catalog/response.go | 42.85% <0.00%> (-2.15%) |
:arrow_down: |
| ... and 123 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Rebased onto current master branch.