flyteplugins icon indicating copy to clipboard operation
flyteplugins copied to clipboard

[WIP] Supporting hyperparameter tuining on custom training job task

Open bnsblue opened this issue 5 years ago • 2 comments

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • [ ] Bug Fix
  • [x] Feature
  • [x] Plugin

Are all requirements met?

  • [x] Code completed
  • [ ] Smoke tested
  • [x] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA OR https://github.com/lyft/flyte/issues/

bnsblue avatar Oct 30 '20 03:10 bnsblue

Codecov Report

Merging #137 into master will increase coverage by 0.29%. The diff coverage is 85.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   61.39%   61.69%   +0.29%     
==========================================
  Files         106      106              
  Lines        5997     6064      +67     
==========================================
+ Hits         3682     3741      +59     
- Misses       1939     1943       +4     
- Partials      376      380       +4     
Impacted Files Coverage Δ
...sks/plugins/k8s/sagemaker/hyperparameter_tuning.go 62.82% <74.64%> (+1.33%) :arrow_up:
...o/tasks/plugins/k8s/sagemaker/plugin_test_utils.go 94.57% <93.93%> (-0.58%) :arrow_down:
go/tasks/plugins/k8s/sagemaker/utils.go 69.08% <100.00%> (+1.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62036f3...b8dd1bc. Read the comment docs.

codecov-io avatar Oct 30 '20 03:10 codecov-io

Moved to https://github.com/flyteorg/flyte/pull/4120

eapolinario avatar Oct 02 '23 21:10 eapolinario