XGBoost Plugin
Signed-off-by: Samhita Alla [email protected]
TL;DR
XGBoost Plugin for ODSC
Type
- [ ] Bug Fix
- [ ] Feature
- [ ] Plugin
Are all requirements met?
- [ ] Code completed
- [ ] Smoke tested
- [ ] Unit tests added
- [ ] Code documentation added
- [ ] Any pending items have an associated Issue
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/
Codecov Report
Merging #734 (6ec0f38) into master (19d977e) will decrease coverage by
0.17%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 85.78% 85.61% -0.18%
==========================================
Files 362 342 -20
Lines 30007 28914 -1093
Branches 2444 2377 -67
==========================================
- Hits 25743 24755 -988
+ Misses 3621 3527 -94
+ Partials 643 632 -11
| Impacted Files | Coverage Δ | |
|---|---|---|
| flytekit/models/core/compiler.py | 84.21% <0.00%> (-5.40%) |
:arrow_down: |
| flytekit/common/tasks/generic_spark_task.py | 54.05% <0.00%> (-3.45%) |
:arrow_down: |
| flytekit/common/interface.py | 86.30% <0.00%> (-2.74%) |
:arrow_down: |
| flytekit/common/types/proto.py | 75.88% <0.00%> (-2.13%) |
:arrow_down: |
| flytekit/common/tasks/task.py | 62.50% <0.00%> (-0.70%) |
:arrow_down: |
| flytekit/engines/common.py | 78.94% <0.00%> (-0.66%) |
:arrow_down: |
| flytekit/common/workflow.py | 60.30% <0.00%> (-0.60%) |
:arrow_down: |
| flytekit/common/launch_plan.py | 69.36% <0.00%> (-0.53%) |
:arrow_down: |
| flytekit/common/tasks/presto_task.py | 77.08% <0.00%> (-0.47%) |
:arrow_down: |
| flytekit/common/types/primitives.py | 94.37% <0.00%> (-0.41%) |
:arrow_down: |
| ... and 106 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 19d977e...6ec0f38. Read the comment docs.
I am not sure why we are using CSV Files. My preference is that we use FlyteSchema and then load CSV into FlyteSchema or have a task to transform it. That being said cc @wild-endeavor we should probably make CSV a valid type of schema?
@kumare3, let me know if everything looks okay. I can then copy this to the ODSC repo.