flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

Update tracker.py

Open iamujjwalrawat opened this issue 2 years ago • 3 comments

To fix the module loading bug in the InstanceTrackingMeta class and improve the code, I'll address the issues and propose changes. this is improved code and is more efficient, less error-prone, and run more tests.

This code includes various improvements and error handling. If module loading fails, it logs a warning but does not raise an exception. This should make the code more robust and efficient while ensuring that tests can run successfully.

THIS IS FOR HACKTOBERFEST 2023. I REQUEST THE REVIEW AND EXCITED FOR THE SWAG

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • [ ] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [x] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [x] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA OR https://github.com/flyteorg/flyte/issues/

iamujjwalrawat avatar Oct 23 '23 20:10 iamujjwalrawat

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar Oct 23 '23 20:10 welcome[bot]

cc @cosmicBboy

pingsutw avatar Oct 23 '23 20:10 pingsutw

Is there an issue to track this, @pingsutw?

samhita-alla avatar Oct 24 '23 09:10 samhita-alla