flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

(Re-opened) Add TypeTransformer for TensorFlow tensor

Open VPraharsha03 opened this issue 3 years ago • 2 comments

This PR adds support for tf.Tensor as a native flyte type

Type

  • [ ] Bug Fix
  • [ ] Feature
  • [X] Plugin

Are all requirements met?

  • [X] Code completed
  • [ ] Smoke tested
  • [X] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

  • Adds a TypeTransformer for tf.Tensor in flytekit/extras/tensorflow/tensor/tensor.py
  • ~~Note : I'm working on the tests and will be soon adding them.~~ Done.

Tracking Issue

https://github.com/flyteorg/flyte/issues/2569

Follow-up issue

NA

VPraharsha03 avatar Oct 29 '22 19:10 VPraharsha03

Codecov Report

Merging #1269 (9fea1cf) into master (9e40690) will increase coverage by 0.05%. The diff coverage is 92.45%.

:exclamation: Current head 9fea1cf differs from pull request most recent head ad6e863. Consider uploading reports for the commit ad6e863 to get more accurate results

@@            Coverage Diff             @@
##           master    #1269      +/-   ##
==========================================
+ Coverage   68.86%   68.92%   +0.05%     
==========================================
  Files         287      290       +3     
  Lines       26446    26455       +9     
  Branches     2499     2123     -376     
==========================================
+ Hits        18212    18233      +21     
+ Misses       7749     7737      -12     
  Partials      485      485              
Impacted Files Coverage Δ
flytekit/extras/tensorflow/__init__.py 55.55% <55.55%> (ø)
flytekit/extras/tensorflow/tensor.py 89.47% <89.47%> (ø)
...sts/flytekit/unit/extras/tensorflow/test_tensor.py 100.00% <100.00%> (ø)
...kit/unit/extras/tensorflow/test_transformations.py 100.00% <100.00%> (ø)
flytekit/clis/sdk_in_container/init.py 66.66% <0.00%> (-33.34%) :arrow_down:
flytekit/types/file/__init__.py 0.00% <0.00%> (-17.95%) :arrow_down:
flytekit/deck/deck.py 34.04% <0.00%> (-4.42%) :arrow_down:
flytekit/types/directory/types.py 54.16% <0.00%> (-1.58%) :arrow_down:
...ests/flytekit/unit/core/test_realworld_examples.py 59.70% <0.00%> (-0.60%) :arrow_down:
flytekit/core/promise.py 51.39% <0.00%> (-0.56%) :arrow_down:
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 30 '22 20:10 codecov[bot]

@samhita-alla Done with the changes, can I get a Hacktoberfest accepted label?

VPraharsha03 avatar Oct 31 '22 11:10 VPraharsha03