[Housekeeping] Files used in `data_types_and_io.normalize_csv_file` and `data_types_and_io.download_and_normalize_csv_files` are no longer accessible
Describe the issue
We should change the files mentioned in these workflows:
- https://github.com/flyteorg/flytesnacks/blob/2730d5634a88d08bcf8666ffec141915514b5787/examples/data_types_and_io/data_types_and_io/file.py#L78-L83
- https://github.com/flyteorg/flytesnacks/blob/2730d5634a88d08bcf8666ffec141915514b5787/examples/data_types_and_io/data_types_and_io/folder.py#L100-L101
Since those are not publicly available anymore
What if we do not do this?
We'll have unrunnable code in our docs and functional tests will have less coverage.
Related component(s)
flytesnacks
Are you sure this issue hasn't been raised already?
- [X] Yes
Have you read the Code of Conduct?
- [X] Yes
Issue Title: [Housekeeping] Files used in data_types_and_io.normalize_csv_file and data_types_and_io.download_and_normalize_csv_files are no longer accessible
Issue Body:
Describe the issue
We should change the files mentioned in these workflows:
- https://github.com/flyteorg/flytesnacks/blob/2730d5634a88d08bcf8666ffec141915514b5787/examples/data_types_and_io/data_types_and_io/file.py#L78-L83
- https://github.com/flyteorg/flytesnacks/blob/2730d5634a88d08bcf8666ffec141915514b5787/examples/data_types_and_io/data_types_and_io/folder.py#L100-L101
Since those are not publicly available anymore
What if we do not do this?
We'll have unrunnable code in our docs and functional tests will have less coverage.
Related component(s)
flytesnacks
Are you sure this issue hasn't been raised already?
- [X] Yes
Have you read the Code of Conduct?
- [X] Yes
Sources:
This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.
Mention @runllm to ask follow-up questions. See runllm.com for more!
@eapolinario I found the new location of these files: https://people.sc.fsu.edu/~jburkardt/data/csv/csv.html
We should probably make local copies of the biostats.csv and faithful.csv files
We should probably make local copies of the biostats.csv and faithful.csv files
agreed. We should mention the source and what time we made a local copy of those files.
Actually, the files were restored to their original locations. This PR is not needed anymore. Let's follow up on a separate PR to make local copies and give the right attribution.
Noting that per the website they're hosted on, the files are licensed under the GNU LGPL license.. I made local copies of the files 23 May 2024 (will use this information when I update the related image and docs). We should credit John Burkardt, computational scientist at Virginia Tech, former research professor at Florida State University.
Thank you, @neverett !