flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Initial WIP on CustomInfo for agents

Open ddl-ebrown opened this issue 1 year ago • 1 comments

Goes with https://github.com/flyteorg/flytekit/pull/2426

I was able to get the agent sending back CustomInfo as part of the calls to GetTask, but unfortunately it looks like the server doesn't do anything with them. This PR aims to fix that.

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

ddl-ebrown avatar May 19 '24 03:05 ddl-ebrown

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.10%. Comparing base (2f1f813) to head (433d879). Report is 430 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5391      +/-   ##
==========================================
+ Coverage   61.08%   61.10%   +0.01%     
==========================================
  Files         793      793              
  Lines       51156    51158       +2     
==========================================
+ Hits        31251    31259       +8     
+ Misses      17033    17027       -6     
  Partials     2872     2872              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (+0.04%) :arrow_up:
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.95% <100.00%> (+<0.01%) :arrow_up:
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 19 '24 03:05 codecov[bot]

Cleaning stale PRs. Please reopen if you wan to discuss this further.

eapolinario avatar Mar 03 '25 18:03 eapolinario