flyte Add appProtocol to agent service to allow agent to work with istio

Why are the changes needed?

If you try to use an agent on a cluster with istio, flytepropeller is unable to connect to the agent. You will either need to remove the agent from flytepropeller's configmap or flytepropeller will fail on startup.

Connecting to flyteconsole is also broken in istio because missing appProtocol prevents some http ports from working correctly.

What changes were proposed in this pull request?

Specify an appProtocol that istio can use to determine how to proxy requests (see here for more details on how this works).

Update: I also modified the flyteadmin and flyteconsole services so that they will work with istio as well. More extensive changes are necessary to get everything working, but I will split those into a separate PR as they are likely more controversial

How was this patch tested?

Tested on my flyte deployment with istio enabled for the whole cluster.

Setup process

Screenshots

Check all the applicable boxes

[ ] I updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] All commits are signed-off.

Related PRs

Docs link

Apr 17 '24 00:04 noahjax

I think you just need to run the local tools to update the generated files and such:

HELM_SKIP_INSTALL=true make helm

Apr 17 '24 00:04 ddl-ebrown

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.99%. Comparing base (37fe0a3) to head (8590993). Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5240   +/-   ##
=======================================
  Coverage   60.99%   60.99%           
=======================================
  Files         794      794           
  Lines       51475    51475           
=======================================
  Hits        31398    31398           
  Misses      17185    17185           
  Partials     2892     2892

Flag	Coverage Δ
unittests-datacatalog	`69.31% <ø> (ø)`
unittests-flyteadmin	`58.73% <ø> (ø)`
unittests-flytecopilot	`17.79% <ø> (ø)`
unittests-flytectl	`68.03% <ø> (ø)`
unittests-flyteidl	`79.04% <ø> (ø)`
unittests-flyteplugins	`61.85% <ø> (ø)`
unittests-flytepropeller	`57.30% <ø> (ø)`
unittests-flytestdlib	`65.59% <ø> (ø)`