flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Remove extra EKS values file from flyte-binary

Open davidmirror-ops opened this issue 1 year ago • 2 comments

Why are the changes needed?

What changes were proposed in this pull request?

This PR removes a values file that doesn't contain anything new compared to the eks-starter.yaml file provided.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [X] All commits are signed-off.

Related PRs

Docs link

davidmirror-ops avatar Apr 10 '24 16:04 davidmirror-ops

@pingsutw I think the idea here is aligning with the other charts where a single starter values file is provided. What's considered "production-grade" varies a lot per organizations. Even this "starter" file is opinionated (eg. is ingress considered "starter"?) So I guess having the most common overrides on a values file is what we could look for :)

davidmirror-ops avatar Apr 10 '24 21:04 davidmirror-ops

Ah, I see; that makes sense to me.

pingsutw avatar Apr 10 '24 21:04 pingsutw