flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Fix flyte-core rendering when flyteagent enabled

Open ddl-ebrown opened this issue 1 year ago • 1 comments

  • Flyte agent now tries to render a specific set of podLabels, so assumes that there is an empty podLabels: {} set. This change to values.yaml for flyte-core ensures empty values are there.

  • Fixes:

    Error: template: flyte-core/charts/flyteagent/templates/agent/deployment.yaml:17:17: executing "flyte-core/charts/flyteagent/templates/agent/deployment.yaml" at <include "flyteagent.podLabels" .>: error calling include: template: flyte-core/templates/_helpers.tpl:122:16: executing "flyteagent.podLabels" at <.Values.flyteagent.podLabels>: nil pointer evaluating interface {}.podLabels

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

ddl-ebrown avatar Feb 20 '24 21:02 ddl-ebrown

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e58e3d3) 58.92% compared to head (f854f1e) 58.91%. Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4922      +/-   ##
==========================================
- Coverage   58.92%   58.91%   -0.02%     
==========================================
  Files         645      645              
  Lines       55394    55394              
==========================================
- Hits        32640    32634       -6     
- Misses      20171    20177       +6     
  Partials     2583     2583              
Flag Coverage Δ
unittests 58.91% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 20 '24 21:02 codecov[bot]