[WIP] add `Running Phase with Message` for Flytepropeller
Tracking issue
https://github.com/flyteorg/flyte/issues/3936
Why are the changes needed?
We want to support messages and loglinks for agent tasks like databricks agent.
Important Messages
If we remove these 3 lines, flytepropeller can't pass loglinks to flyteadmin, and flyteconsole can't show the loglinks. This function will affect how loglinks will be printed or not, but I still couldn't find it why running phase can't show messages and loglinks when updated, will try more.
https://github.com/flyteorg/flyte/blob/master/flytepropeller/pkg/controller/nodes/task/transformer.go#L179-L182
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
- [ ] I updated the documentation accordingly.
- [x] All new and existing tests passed.
- [x] All commits are signed-off.
Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.
Comparison is base (
4223a83) 58.98% compared to head (a06382c) 59.41%. Report is 1 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| ...lyteplugins/go/tasks/pluginmachinery/core/phase.go | 0.00% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #4844 +/- ##
==========================================
+ Coverage 58.98% 59.41% +0.42%
==========================================
Files 644 567 -77
Lines 55146 43589 -11557
==========================================
- Hits 32529 25899 -6630
+ Misses 20043 15296 -4747
+ Partials 2574 2394 -180
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 60.59% <33.33%> (+1.61%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.