flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[Docs] Spot/interruptible docs imply retries come from the user retry budget

Open andrewwdye opened this issue 2 years ago • 6 comments

Description

In the spot/interruptible docs we have the following note

If you set retries=n, for instance, and the task gets preempted repeatedly, Flyte will retry on a preemptible/spot instance n-1 times and for the last attempt will retry your task on a non-spot (regular) instance. Please note that tasks will only be retried if at least one retry is allowed using the retries parameter in the task decorator.

This implies that interruptible retries come from the user-specified user error retry budget. However, in practice spot interruptions are taken from the system retry budget.

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

andrewwdye avatar Aug 14 '23 18:08 andrewwdye

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏

github-actions[bot] avatar May 15 '24 00:05 github-actions[bot]

Keep it open

davidmirror-ops avatar May 15 '24 13:05 davidmirror-ops

Hi! I would like to work on this issue

RaghavMangla avatar Oct 04 '24 20:10 RaghavMangla

@RaghavMangla thanks for your willingness to contribute. Considering you already have 6 issues assigned to you, and following the principle of "first come first serve" we'd like to encourage you to send PRs for the issues where you are already an assignee and then, if no one has taken this one, we can assign to you. Thanks in advance :)

davidmirror-ops avatar Oct 05 '24 12:10 davidmirror-ops

Yes, sure

On Sat, 5 Oct, 2024, 17:31 David Espejo, @.***> wrote:

@RaghavMangla https://github.com/RaghavMangla thanks for your willingness to contribute. Considering you already have 6 issues assigned to you, and following the principle of "first come first serve" we'd like to encourage you to send PRs for the issues where you are already an assignee and then, if no one has taken this one, we can assign to you. Thanks in advance :)

— Reply to this email directly, view it on GitHub https://github.com/flyteorg/flyte/issues/3956#issuecomment-2395032988, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXGSZMNBD72P3UPL2LDEBZ3ZZ7IKHAVCNFSM6AAAAAA3QCARIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGAZTEOJYHA . You are receiving this because you were mentioned.Message ID: @.***>

RaghavMangla avatar Oct 05 '24 14:10 RaghavMangla

??

On Sat, 5 Oct, 2024, 20:00 Raghav Mangla, @.***> wrote:

Yes, sure

On Sat, 5 Oct, 2024, 17:31 David Espejo, @.***> wrote:

@RaghavMangla https://github.com/RaghavMangla thanks for your willingness to contribute. Considering you already have 6 issues assigned to you, and following the principle of "first come first serve" we'd like to encourage you to send PRs for the issues where you are already an assignee and then, if no one has taken this one, we can assign to you. Thanks in advance :)

— Reply to this email directly, view it on GitHub https://github.com/flyteorg/flyte/issues/3956#issuecomment-2395032988, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXGSZMNBD72P3UPL2LDEBZ3ZZ7IKHAVCNFSM6AAAAAA3QCARIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGAZTEOJYHA . You are receiving this because you were mentioned.Message ID: @.***>

RaghavMangla avatar Oct 06 '24 06:10 RaghavMangla

i want to work on this issue

ap0calypse8 avatar Oct 29 '24 18:10 ap0calypse8

@ap0calypse8 thank you!

davidmirror-ops avatar Oct 29 '24 19:10 davidmirror-ops