Deletion of artifacts
TL;DR
This PR implements deletion of artifacts from datacatalog's database as well as underlying blob storage.
Type
- [ ] Bug Fix
- [X] Feature
- [ ] Plugin
Are all requirements met?
- [X] Code completed
- [X] Smoke tested
- [X] Unit tests added
- [X] Code documentation added
- [ ] Any pending items have an associated Issue
Complete description
Datacatalog now supports deletion of artifacts (either via tag or artifact ID), removing the entry from the DB as well as underlying blob storage. Additional prometheus metrics for deletion have been added as well. This is required for evicting the cache of past executions via flyteadmin.
The PR was created as a draft until the flyteidl and flytestdlib PRs have been merged and respective versions have been published.
Tracking Issue
https://github.com/flyteorg/flyte/issues/2867
Follow-up issue
NA
Codecov Report
Merging #87 (51ccd78) into master (faa86db) will increase coverage by
1.24%. The diff coverage is82.02%.
:exclamation: Current head 51ccd78 differs from pull request most recent head 2e80fba. Consider uploading reports for the commit 2e80fba to get more accurate results
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 68.41% 69.66% +1.24%
==========================================
Files 31 31
Lines 1656 1744 +88
==========================================
+ Hits 1133 1215 +82
- Misses 445 448 +3
- Partials 78 81 +3
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 69.66% <82.02%> (+1.24%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/repositories/gormimpl/artifact.go | 82.03% <79.54%> (-0.90%) |
:arrow_down: |
| pkg/manager/impl/artifact_manager.go | 73.91% <84.44%> (+4.81%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.