flycast icon indicating copy to clipboard operation
flycast copied to clipboard

Adds Start, Stop, Reload lua items

Open NBeing opened this issue 4 years ago • 2 comments

Allows user to stop / start / reload lua from the emulator menu. This will be useful for changing lua files along with the lua file specifier in the other commit.

NBeing avatar Nov 19 '21 23:11 NBeing

Sorry for the delay.

The code looks good but I don't like having Lua stuff on the pause menu. Too many buttons already and 99% of users won't be using Lua (or at least won't need to start/stop it). So I'd rather have these buttons in Settings > Advanced > Lua Scripting.

I totally understand the need for a hardcore lua developer to start/stop the runtime easily but it's probably best to use a custom build for this.

Another (minor) thing: I'm not sure the isLuaRunning flag is needed. You could check if the lua_State (L) is null or not.

flyinghead avatar Nov 25 '21 09:11 flyinghead

If it's possible, maybe it should be advanced emulator hotkeys? That prevents the hassle of menus.

i30817 avatar May 12 '22 02:05 i30817