flycheck icon indicating copy to clipboard operation
flycheck copied to clipboard

fix(stylelint): stylelint v14 uses incompatible cli arguments

Open Fuco1 opened this issue 3 years ago • 10 comments

Detect the major version of stylelint, and for verion 14 don't pass the --syntax argument.

Fixes #1912

Fuco1 avatar May 23 '22 13:05 Fuco1

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 23 '22 13:05 CLAassistant

Do we care to support versions < 14? If so, we can merge this, but otherwise we could simply remove --syntax entirely?

cpitclaudel avatar Jun 24 '22 03:06 cpitclaudel

v14 was released 8 months ago, I don't know if that's too much time or too little. I only started using it a month ago so jumped right on v14, no idea how difficult the migration is.

Fuco1 avatar Jun 24 '22 13:06 Fuco1

For what it's worth stylelint versions less than 14 are still getting 1 million+ downloads a week on npm.

justinbarclay avatar Jun 27 '22 21:06 justinbarclay

@cpitclaudel @bbatsov @marsam @jcs090218 can we get this merged please?

wyuenho avatar Feb 25 '23 18:02 wyuenho

I rebased it and pushed now.

Fuco1 avatar Feb 25 '23 19:02 Fuco1

@marsam could we please merge this PR?

rekenerd avatar Jan 24 '24 15:01 rekenerd

@bbatsov ^

wyuenho avatar Feb 04 '24 19:02 wyuenho

@Fuco1 I'd like to finally merge this, but so much time has passed that I'd propose to just drop support for older versions and mention this in the checker's docs. I see little point in adding the extra complexity for a version that's probably used by no one at this point.

bbatsov avatar Feb 04 '24 21:02 bbatsov

@Fuco1 ping :-)

bbatsov avatar Feb 24 '24 07:02 bbatsov

Sure, this is almost two years old now so the v13 style lint is almost 3 years old. Not much value in this anymore (we switched to styled components anyway :D)

Fuco1 avatar Mar 15 '24 17:03 Fuco1