flagger icon indicating copy to clipboard operation
flagger copied to clipboard

Support: Multiple Contour Ingress controllers not supported

Open AshDerTest opened this issue 4 years ago • 0 comments

Describe the bug

Currently have multiple contour ingress controllers, internal and external deployed using the contour helm chart with 2 different ingress classes defined. Flagger using contour mesh provider (ingress) currently has the limitation of only defining 1 ingress class name in flagger for the canary to create the relevant httpproxy as defined in code below: (https://github.com/fluxcd/flagger/blob/e6c740d917bdb3da5163bdef41b66ce8d20f31bf/pkg/router/contour.go)

To Reproduce

  1. Deploy 2 Contour ingress controllers with different ingresscalss names.
  2. Deploy Flagger with mesh provider= contour and ingressclass= ""
  3. Deploy 2 instances of test application linked to each ingress class
  4. Deploy Flagger Canary

Note this will only work for the one instance of the application

Expected behavior

  1. The ability to define the ingressclass name as part of the canary instead of the flagger deployment to create the httpproxy. 2.OR the ability to pre define the httppproxy manually to be used by the canary

Additional context

  • Flagger version: 1.13.0
  • Kubernetes version: 1.22
  • Service Mesh provider: -
  • Ingress provider: Contour

AshDerTest avatar Oct 21 '21 12:10 AshDerTest