flagger icon indicating copy to clipboard operation
flagger copied to clipboard

rollout webhook is not executed

Open 13567436138 opened this issue 4 years ago • 0 comments

Describe the bug

A clear and concise description of what the bug is. Please provide the Canary definition and Flagger logs.

To Reproduce

release/canary/flagger/reviews-hpa.yaml 

kubectl  apply -f reviews-hpa.yaml  -n istio


apiVersion: autoscaling/v1
kind: HorizontalPodAutoscaler
metadata:
  name: review-hpa
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: reviews-v1
  minReplicas: 1
  maxReplicas: 2
  targetCPUUtilizationPercentage: 50


release/canary/flagger/canary-reviews-webhook-rollout.yaml

kubectl apply -f canary-reviews-webhook-rollout.yaml -n istio


apiVersion: flagger.app/v1beta1
kind: Canary
metadata:
  name: bookinfo
spec:
  revertOnDeletion: true
  targetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: reviews-v1
  autoscalerRef:
    apiVersion: autoscaling/v1
    kind: HorizontalPodAutoscaler
    name: review-hpa
  service:
    port: 9080
    gateways:
    - istio/bookinfo-gateway
    hosts:
    - "*"
  analysis:
    interval: 1m
    threshold: 10
    maxWeight: 50
    stepWeight: 20
    metrics:
      - name: request-success-rate
        thresholdRange:
          min: 99
        interval: 1m
      - name: request-duration
        thresholdRange:
          max: 500
        interval: 1m
    webhooks:
      - name: "start gate"
        type: confirm-rollout
        url: http://flagger-loadtester.istio-system/gate/approve
#      - name: "helm test"
#        type: pre-rollout
#        url: http://flagger-loadtester.istio-system/
#        timeout: 3m
#        metadata:
#          type: "helmv3"
#          cmd: "test reviews -n istio"
      - name: "load test"
        type: rollout
        url: http://flagger-loadtester.istio-system/
        timeout: 15s
        metadata:
          cmd: "hey -z 1m -q 5 -c 2 http://reviews.istio:9080/reviews/0/"
      - name: "traffic increase gate"
        type: confirm-traffic-increase
        url: http://flagger-loadtester.istio-system/gate/approve
      - name: "promotion gate"
        type: confirm-promotion
        url: http://flagger-loadtester.istio-system/gate/approve
#      - name: "notify"
#        type: post-rollout
#        url: http://telegram.bot:8080/
#        timeout: 5s
#        metadata:
#          some: "message"
      - name: "rollback gate"
        type: rollback
        url: http://flagger-loadtester.istio-system/rollback/check
      - name: "send to Slack"
        type: event
        url: https://hooks.slack.com/services/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
        metadata:
          environment: "test"
          cluster: "flagger-test" 



kubectl -n istio set image deployment/reviews-v1 reviews=docker.io/istio/examples-bookinfo-reviews-v1:1.16.2



启用压测
go-stress-testing -c 10 -n 1000000 -u http://bookinfo.com:31773/reviews/0

 kubectl describe canary bookinfo -n istio
 没有pre-rollout,rollout,post-rollout called

  Type     Reason  Age                    From     Message
  ----     ------  ----                   ----     -------
  Normal   Synced  8m33s                  flagger  Confirm-rollout check start gate passed
  Normal   Synced  7m33s                  flagger  New revision detected! Restarting analysis for reviews-v1.istio
  Normal   Synced  6m33s                  flagger  Starting canary analysis for reviews-v1.istio
  Normal   Synced  6m32s                  flagger  Advance bookinfo.istio canary weight 20
  Warning  Synced  5m33s                  flagger  Halt bookinfo.istio advancement request duration 606ms > 500ms
  Normal   Synced  4m32s                  flagger  Advance bookinfo.istio canary weight 40
  Normal   Synced  3m32s                  flagger  Advance bookinfo.istio canary weight 60
  Normal   Synced  2m33s (x4 over 6m32s)  flagger  Confirm-traffic-increase check traffic increase gate passed
  Normal   Synced  2m33s (x5 over 6m33s)  flagger  Rollback hook rollback gate not signaling a rollback
  Normal   Synced  2m32s                  flagger  Confirm-promotion check promotion gate passed
  Normal   Synced  33s (x3 over 2m32s)    flagger  (combined from similar events): Promotion completed! Scaling down reviews-v1.istio
[root@node01 ~]# 



Expected behavior

A clear and concise description of what you expected to happen.

Additional context

  • Flagger version:
  • Kubernetes version:
  • Service Mesh provider:
  • Ingress provider:

13567436138 avatar Sep 06 '21 01:09 13567436138