sidekick icon indicating copy to clipboard operation
sidekick copied to clipboard

why does isFvmInstalled() check for git executable

Open prasadsunny1 opened this issue 1 year ago • 1 comments

I was exploring how sidekick executes shell commands and found isFvmInstalled check for git, I think its a mistake and it should be checking for fvm instead.

https://github.com/fluttertools/sidekick/blob/356124bea7bc3c9bcd0373f1903a836d2204c569/lib/src/modules/compatibility_checks/compat.utils.dart#L23C2-L29C2

Future<bool> isFvmInstalled() async {
  final fvmRes = await which("git");
  if (fvmRes != null) {
    return true;
  }
  return false;
}

prasadsunny1 avatar Apr 14 '24 18:04 prasadsunny1

yep! FVM comes included with Sidekick so the check might not even be needed

aguilaair avatar Apr 15 '24 23:04 aguilaair

@aguilaair We can close this issue.

charles0122 avatar Sep 04 '24 09:09 charles0122