plus_plugins icon indicating copy to clipboard operation
plus_plugins copied to clipboard
verified publisher icon fluttercommunity

fix(share_plus): #3322 Image preview on iOS downscale to avoid issues

Open Victor-Plaud opened this issue 1 year ago • 3 comments

Description

On iPhone 13, when sharing an image and the image is very large, the sharing box may occasionally fail to be awakened.

Related Issues

  • fix: #3322

Checklist

  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] I titled the PR using Conventional Commits.
  • [ ] I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • [ ] All existing and new tests are passing.
  • [ ] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • [x] No, this is not a breaking change.

Victor-Plaud avatar Oct 16 '24 07:10 Victor-Plaud

Hello, thanks for the contribution.

I'd please ask you to follow the PR template: https://github.com/fluttercommunity/plus_plugins/blob/main/.github/PULL_REQUEST_TEMPLATE.md and fix the title.

As well, try to provide more context about this fix, ideally creating a bug report showcasing the issue, or showing before and after images, etc. otherwise it is very hard to understand what the purpose of the fix is.

miquelbeltran avatar Oct 16 '24 07:10 miquelbeltran

Thanks for providing a ticket with a video recording! Can you show a recording of how it looks with the fix?

miquelbeltran avatar Oct 17 '24 07:10 miquelbeltran

https://github.com/user-attachments/assets/568a816f-f2f3-49c1-b46e-2c26810fa1e4

Victor-Plaud avatar Oct 18 '24 11:10 Victor-Plaud