plus_plugins icon indicating copy to clipboard operation
plus_plugins copied to clipboard

[Request]: share_plus android remove url_launcher

Open git-xiaocao opened this issue 3 years ago • 1 comments

Plugin

share_plus

Use case

url_launcher is not required when compiling android but it will also be loaded into the app's gradle project

Proposal

Remove url_launcher when compiling android

git-xiaocao avatar Sep 16 '22 09:09 git-xiaocao

makes sense, feel free to submit a PR if you think you can do it!

miquelbeltran avatar Sep 16 '22 13:09 miquelbeltran

url_launcher is in dependency of share_plus_linux and share_plus_web how can we stop it from being importing in android build, Can anybody guid me?

aakash-pamnani avatar Oct 01 '22 11:10 aakash-pamnani

I feel it's only possible if we have federated plugins.

SirusCodes avatar Oct 22 '22 21:10 SirusCodes

I feel it's only possible if we have federated plugins.

Nope, the dependency would still be there through the other platform dependency unfortunately

miquelbeltran avatar Oct 23 '22 11:10 miquelbeltran

Nope, the dependency would still be there through the other platform dependency unfortunately

Then only way is to have platform channels for each😕

SirusCodes avatar Oct 23 '22 12:10 SirusCodes

Since url_launcher is fully federated, you could in theory depend directly on url_launcher_linux and url_launcher_web instead of url_launcher. You'd have to code against the platform interface directly instead of the app-facing API though.

stuartmorgan-g avatar Oct 24 '22 15:10 stuartmorgan-g

Would make a PR for it then thanks @stuartmorgan for the idea

SirusCodes avatar Oct 24 '22 15:10 SirusCodes