plus_plugins icon indicating copy to clipboard operation
plus_plugins copied to clipboard

Update manifest with explicit minimum sdk level

Open ChristianEdwardPadilla opened this issue 3 years ago • 1 comments

Need minimum of 22 to support Intent#createChooser.

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [x] All existing and new tests are passing.
  • [x] I updated the version in pubspec.yaml and CHANGELOG.md.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] The analyzer (flutter analyze) does not report any problems on my PR.
  • [x] I read and followed the Flutter Style Guide.
  • [x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • [x] No, this is not a breaking change.

ChristianEdwardPadilla avatar Sep 07 '22 02:09 ChristianEdwardPadilla

Hi @ChristianEdwardPadilla can you elaborate on this change?

My guess is that the plugin was originally using Intent.createChooser(Intent, CharSequence) https://developer.android.com/reference/android/content/Intent#createChooser(android.content.Intent,%20java.lang.CharSequence), which is available since API 1, but now it uses https://developer.android.com/reference/android/content/Intent#createChooser(android.content.Intent,%20java.lang.CharSequence,%20android.content.IntentSender) Intent.createChooser(Intent, CharSequence, IntentSender) for the shareWithResult method.

So, if an app is still using share, they are fine without the API 22 requirement. However, if an app wants to use shareWithResult then it is mandatory to use API 22 at least.

I think it would be better to document this and/or add an exception if someone tries to use shareWithResult on API 21 or less.

miquelbeltran avatar Sep 07 '22 15:09 miquelbeltran

Closing as we are not merging this PR.

vbuberen avatar Sep 30 '22 14:09 vbuberen