tests icon indicating copy to clipboard operation
tests copied to clipboard

Update the DevTools hash to the latest.

Open kenzieschmoll opened this issue 6 months ago • 1 comments

kenzieschmoll avatar Jun 24 '25 15:06 kenzieschmoll

@justinmc Looks like the checks are failing on the patrol customer tests, which I saw on https://github.com/flutter/flutter/pull/170544 too. Have you already reached out to folks from leancode to address these tests? Should I send a separate PR to disable them while they are broken?

Processing ./registry/patrol.test...
Created temporary directory: /var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/flutter_customer_testing.patrol.EpNspz
>> git clone https://github.com/leancodepl/patrol.git tests
| Cloning into 'tests'...
>> git -C tests checkout b8bcebf96ff13e37fdc5474804d68e2352e472a4
| HEAD is now at b8bcebf9 chore: Add note to readme to explain branch purpose
Updating code in /var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/flutter_customer_testing.patrol.EpNspz/tests/packages/patrol_cli...
>> flutter packages get
| Resolving dependencies...
| Because leancode_lint >=14.3.0 <14.4.0 depends on analyzer ^6.7.0 and analyzer >=6.6.0 <6.9.0 depends on macros >=0.1.2-main.3 <0.1.3, leancode_lint >=14.3.0 <14.4.0 requires macros >=0.1.2-main.3 <0.1.3 or analyzer ^6.9.0.
| Because macros >=0.1.2-main.4 <0.1.3-main.0 depends on _macros 0.3.2 from sdk and macros >=0.1.2-main.2 <0.1.2-main.4 depends on _macros 0.3.1 from sdk, macros >=0.1.2-main.2 <0.1.3-main.0 requires _macros 0.3.1 or 0.3.2 from sdk.
| Thus, leancode_lint >=14.3.0 <14.4.0 requires analyzer ^6.9.0 or _macros 0.3.1 or 0.3.2 from sdk.
| And because leancode_lint >=14.4.0 <15.1.0 depends on analyzer ^6.11.0, leancode_lint >=14.3.0 <15.1.0 requires analyzer ^6.9.0 or _macros 0.3.1 or 0.3.2 from sdk.
| And because analyzer >=6.9.0 <7.3.0 depends on macros >=0.1.3-main.0 <0.1.4 which depends on _macros 0.3.3 from sdk, leancode_lint >=14.3.0 <15.1.0 requires _macros 0.3.1 or 0.3.2 or 0.3.3 from sdk.
| So, because _macros from sdk doesn't exist (could not find package _macros in the Dart SDK) and patrol_cli depends on leancode_lint ^14.3.0, version solving failed.
|
|
| You can try the following suggestion to make the pubspec resolve:
| * Try upgrading your constraint on leancode_lint: flutter pub add dev:leancode_lint:^17.0.0
| Failed to update packages.
ERROR: Could not run "flutter pub get" in packages/patrol_cli, which was specified as an update directory.
Deleting temporary directory...
Contacts: [email protected], [email protected], [email protected], [email protected]

kenzieschmoll avatar Jun 24 '25 20:06 kenzieschmoll

@kenzieschmoll I have not, thanks for noticing that. I'm about to be OOO for a week so no rush on my side. Maybe I can check in when I'm back and then disable them if they're still broken?

justinmc avatar Jun 26 '25 23:06 justinmc

@kenzieschmoll Now that https://github.com/flutter/tests/pull/462 is merged and devtools tests are disabled, I guess I no longer have a dependency on this PR for my work. Maybe once you all have fixed the devtools tests then this PR can be used to update to that new SHA.

justinmc avatar Jul 14 '25 17:07 justinmc

Closing this. @elliette will address https://github.com/flutter/flutter/issues/172037 to re-enable the DevTools customer tests.

kenzieschmoll avatar Jul 14 '25 17:07 kenzieschmoll

Sounds good, thanks for your help!

justinmc avatar Jul 14 '25 22:07 justinmc