samples icon indicating copy to clipboard operation
samples copied to clipboard

[experimental] retire directory

Open ericwindmill opened this issue 1 year ago • 13 comments

Experimental samples are not appropriate for this repository, because Flutter developers can't use them as a guide today, which is one of the requirements for this repository. See contributing guide for more information.

ericwindmill avatar Dec 02 '24 19:12 ericwindmill

Part of the reason for this directory was the needs of the Material team to have a place for code at master/main because that is where they live. Retirement of this directory would cut off that source of maintenance. I'd suggest that you should discuss this with the owners of the various experimental samples before shuttering this.

domesticmouse avatar Dec 02 '24 21:12 domesticmouse

Part of the reason for this directory was the needs of the Material team to have a place for code at master/main because that is where they live. Retirement of this directory would cut off that source of maintenance. I'd suggest that you should discuss this with the owners of the various experimental samples before shuttering this.

I plan on talking to all stakeholders before I act on any of the 'retire' issues I created yesterday. I've created the tickets so there's a natural place to have the conversations about individual samples. I fully expect that some of them will be just closed without updates

ericwindmill avatar Dec 03 '24 13:12 ericwindmill

FYI @jonahwilliams the text/font puzzle game demo lives here https://github.com/flutter/samples/tree/main/experimental/varfont_shader_puzzle.

zanderso avatar Dec 03 '24 15:12 zanderso

We're not currently using this sample for anything.

jonahwilliams avatar Dec 03 '24 16:12 jonahwilliams

FYI - These samples can be moved if they're valuable for a reason I don't see and they run on the stable channel today.

ericwindmill avatar Dec 03 '24 16:12 ericwindmill

The date_planner app was checked in to experimental to run against master while we work on iOS improvements, I think the iOS team was also planning to use it for benchmarking. cc @jmagman

We were about to check in rolodex as well in experimental to run against master as we finish polishing Cupertino. cc @MitchellGoodwin

Piinks avatar Dec 04 '24 17:12 Piinks

The date_planner app was checked in to experimental to run against master while we work on iOS improvements, I think the iOS team was also planning to use it for benchmarking. cc @jmagman

The iOS team isn't planning on using this app for benchmarking, afaik. Right @LouiseHsu?

jmagman avatar Dec 04 '24 18:12 jmagman

Yep I wasnt planning on using it.

LouiseHsu avatar Dec 04 '24 18:12 LouiseHsu

Good call, @Piinks, I didn't consider where I'd move date_planner.

I need to consider the best way to handle large demo apps that are in active development, but my gut says that I'm just going to move it out experimental and add whichever qualifiers I need to add to the readme, like that it's incomplete or is tested against master.

FWIW The problem I'm trying to solve by deleting experimental is that it's often a dumping ground where things are checked in and then forgotten. I'm discouraging any samples that can't pass CI against stable as a rule, but all rules have exceptions. 

ericwindmill avatar Dec 04 '24 19:12 ericwindmill

The problem I'm trying to solve by deleting experimental is that it's often a dumping ground where things are checked in and then forgotten.

You have my full support. 💯

If we need to find another home for rolodex and date_planner, can do!

Piinks avatar Dec 04 '24 22:12 Piinks

The pedometer example works on the stable channel even though it's on experimental. It's also maintained by me.

HosseinYousefi avatar Dec 09 '24 10:12 HosseinYousefi

The pedometer example works on the stable channel even though it's on experimental. It's also maintained by me.

Can we move the pedometer out of experimental into the main directory?

domesticmouse avatar Dec 09 '24 18:12 domesticmouse

Can we move the pedometer out of experimental into the main directory?

SGTM!

HosseinYousefi avatar Dec 10 '24 11:12 HosseinYousefi