packages [quick_actions] add localizedSubtitle for iOS

Add the localizedSubtitle field on quick actions for iOS

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
[x] I linked to at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Jun 23 '24 12:06 GiacomoPignoni

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Jun 23 '24 12:06 google-cla[bot]

I like this idea, though what you currently have doesn't compile because the quick_actions_platform_interface doesn't have that parameter. Check out https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-platform-interface-method-parameters

 lib/main.dart:56:9: Error: No named parameter with the name 'localizedSubtitle'.
         localizedSubtitle: 'Action one subtitle',
         ^^^^^^^^^^^^^^^^^
 ../../../../../.pub-cache/hosted/pub.dev/quick_actions_platform_interface-1.0.6/lib/types/shortcut_item.dart:11:9: Context: Found this candidate, but the arguments don't match.
   const ShortcutItem({

Also quick_actions_ios will need its CHANGELOG updated. Take a look at that wiki page for more details about how to contribute to packages. Thank you!

Jun 24 '24 17:06 jmagman

Ok sorry @jmagman, I've added the deps override (as indicated in the documentation), the quick_actions_ios CHANGELOG and also the quick_actions_platform_interface CHANGELOG.

Now I wait for the review, than I'll make a new PR to update only the platform interface

Jun 26 '24 21:06 GiacomoPignoni

Swift format: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8744034268588324081/+/u/Run_package_tests/Swift_format/stdout

Are you able to reproduce this test timeout locally?

12:00 +0 -1: loading /Volumes/Work/s/w/ir/x/w/packages/packages/quick_actions/quick_actions/example/integration_test/quick_actions_test.dart [E]

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8744034268487478385/+/u/Run_package_tests/drive_examples/stdout

Jun 26 '24 21:06 jmagman

@GiacomoPignoni Are you still planning on updating this PR per the review feedback above?

Jul 16 '24 19:07 stuartmorgan-g

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

Aug 20 '24 19:08 stuartmorgan-g

I have created a new one based on this PR, please help to view it. @stuartmorgan

https://github.com/flutter/packages/pull/8038

Nov 08 '24 09:11 sinyu1012