packages
packages copied to clipboard
[go_router]: add optional completer for replaced routes
When route from the stack is replaced, its completer is lost, and causes futures in routes chain to never finish. This change add optional completer that can be passed when pushing / replacing routes that will be completed when route is replaced.
It fixes: https://github.com/flutter/flutter/issues/141251 This PR is continuation of: https://github.com/flutter/packages/pull/6451
CC @chunhtai
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I linked to at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style. - [x] I updated/added relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or this PR is test-exempt.
- [x] All existing and new tests are passing.