packages icon indicating copy to clipboard operation
packages copied to clipboard
verified publisher icon flutter

[go_router_builder] Fix #106121 and #116837 - Fix compile error on the generated code when using $extra and non nullable enums queryParams

Open dancamdev opened this issue 3 years ago • 10 comments

Issues Fixed: https://github.com/flutter/flutter/issues/116837

Relevant https://github.com/flutter/flutter/issues/106121

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

dancamdev avatar Dec 10 '22 16:12 dancamdev

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Dec 10 '22 16:12 flutter-dashboard[bot]

I also think there's room for improvement on how extras are handled.

I'll work on a new issue with proposed changes, I've got a couple of ideas to make improve DX.

We can discuss that and eventually implement it

dancamdev avatar Dec 17 '22 08:12 dancamdev

@dancamdev Are you planning on updating this PR based on the feedback above?

stuartmorgan-g avatar Jan 24 '23 21:01 stuartmorgan-g

Sure, hopefully I find time this week

dancamdev avatar Jan 24 '23 21:01 dancamdev

Meanwhile is there any workaround we can use here?

5hirish avatar Feb 05 '23 17:02 5hirish

@dancamdev are you still planning on coming back to this pr?

chunhtai avatar Feb 09 '23 22:02 chunhtai

The ci is failing, can you fix the failing test?

chunhtai avatar Feb 23 '23 22:02 chunhtai

(triage) Hi @dancamdev are you still plan to work on this PR? If not we can close this PR for now and reopen when you have time to work on it.

chunhtai avatar Mar 02 '23 22:03 chunhtai

It looks like tests are timing out on my end.

Getting this error on Windows

hell: [ERROR:flutter/shell/common/shell.cc(89)] Dart Error: error: import of dart:mirrors is not supported in the current Dart runtime
Shell: [ERROR:flutter/runtime/dart_isolate.cc(144)] Could not prepare isolate.

I'll try to run it on Linux and see if that works

dancamdev avatar Mar 08 '23 12:03 dancamdev

@dancamdev Are you still planning on updating this to address the test issue?

stuartmorgan-g avatar Mar 21 '23 20:03 stuartmorgan-g

Hi @dancamdev I will close this pr for now. Feel free to reopen once you have time to work on this

chunhtai avatar Mar 23 '23 21:03 chunhtai