flutter icon indicating copy to clipboard operation
flutter copied to clipboard

Fixes an issue where TapRegion would consume taps regardless of navigation state

Open PrimaelQuemerais opened this issue 8 months ago • 1 comments

Fixes #169061 Expands on #155297

This PR fixes the issue where TapRegion with consumeOutsideTaps enabled would consume taps even after navigating to a different page.

Pre-launch Checklist

  • [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • [x] I signed the [CLA].
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is [test-exempt].
  • [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • [x] All existing and new tests are passing.

PrimaelQuemerais avatar May 19 '25 13:05 PrimaelQuemerais

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

flutter-dashboard[bot] avatar May 19 '25 13:05 flutter-dashboard[bot]