flutter icon indicating copy to clipboard operation
flutter copied to clipboard

Suppress previous route transition if current route is fullscreenDialog

Open MitchellGoodwin opened this issue 1 year ago • 0 comments

Fixes #159289

Cupertino and Material routes were looking to see if the next route was a full screen dialog route, and not transitioning accordingly. However with the updates to allow mixed transitions in an app, any route will try and transition if a delegatedTransition is available. This PR makes it so that Cupertino and Material routes that are fullscreen dialogs will use canTransitionFrom to tell the previous route not to transition.

Before: 388677067-d301238d-6615-42a7-b60a-611c61136d88.webm

After:

https://github.com/user-attachments/assets/7deb5143-cd67-4696-95ec-9d7df329dfa4

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

MitchellGoodwin avatar Nov 22 '24 00:11 MitchellGoodwin