Clean up the view focus enabler flag
This PR reverts https://github.com/flutter/engine/pull/52527 now that the view focus functionality was fully launched.
This PR should be merged at least 1 week after https://github.com/flutter/engine/pull/54966 is checked in.
Fixes https://github.com/flutter/flutter/issues/153022.
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with
///). - [x] I signed the CLA.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.
(triage) Spoke to @ditman and he said he will land this soon.
Monorepo Migration Completed
TL;DR: Please migrate your PR to flutter/flutter
The flutter/engine repository has been migrated to the flutter/flutter repository. This PR will no longer be landed here and must be migrated. To migrate your PR to the flutter repository, please follow these steps:
-
Create a patch for this PR:
- Generate a patch set that represents the changes in this PR. The exact method will vary depending on your PR's history. If your PR includes merges, it is highly recommended that you rebase it onto
mainfirst.
git format-patch $START_COMMIT..$END_COMMIT --stdout > combined_patch.patch - Generate a patch set that represents the changes in this PR. The exact method will vary depending on your PR's history. If your PR includes merges, it is highly recommended that you rebase it onto
-
Update the patch for the new engine location:
- The engine source code now resides in the
engine/subdirectory within theflutter/flutterrepository. You'll need to update the file paths in your patch accordingly.
# Insert the `engine/` prefix to all paths. Note that this usage works on macOS and # linux versions of sed. sed -i.bak \ -e 's|^\(diff --git a/\)\(.*\) b/\(.*\)|\1engine/\2 b/engine/src/flutter/\3|' \ -e 's|^\(--- a/\)\(.*\)|\1engine/src/flutter/\2|' \ -e 's|^\(\+\+\+ b/\)\(.*\)|\1engine/src/flutter/\2|' \ combined_patch.patch - The engine source code now resides in the
-
Checkout and set up your Flutter development environment:
- Follow the instructions in Setting up the Framework development environment to check out the
flutter/flutterrepository. - Remember to rename the origin remote to
upstream(e.g.,git remote rename origin upstream).
- Follow the instructions in Setting up the Framework development environment to check out the
-
Set up the engine development environment within the monorepo:
- Follow the updated instructions in Setting up the engine environment, paying close attention to the changes in gclient setup and location.
-
Apply the patch to a new branch:
- Create a new branch in your
flutter/flutterrepository. - Apply the updated patch to this branch:
git apply combined_patch.patch - Create a new branch in your
-
Open a new PR:
- Open a new PR in the
flutter/flutterrepository with your changes. - Reference this original PR in the new PR's description using
flutter/engine#<PR_NUMBER>.
- Open a new PR in the
This is a canned message