engine icon indicating copy to clipboard operation
engine copied to clipboard

Fix shouldAttachEngineToActivity default value

Open shts opened this issue 1 year ago • 2 comments

shouldAttachEngineToActivity defalut value is true. but this implementation could return false. if user doesnt set value, it should return default value true.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

shts avatar Mar 11 '24 13:03 shts

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Mar 11 '24 13:03 flutter-dashboard[bot]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 11 '24 13:03 google-cla[bot]

@shts Can you please address the guidance of the bots before we can continue.

chinmaygarde avatar Mar 14 '24 20:03 chinmaygarde

I don't understand what bug this PR is addressing.

johnmccutchan avatar Mar 18 '24 18:03 johnmccutchan

Closing this as stale. Please re-open once progress can be made.

chinmaygarde avatar Mar 28 '24 20:03 chinmaygarde