engine icon indicating copy to clipboard operation
engine copied to clipboard

Remove deprecated calls to updateSemantics in `PlatformDispatcher`

Open a-wallen opened this issue 3 years ago • 1 comments

Removes deprecated updateSemantics APIs from PlatformDispatcher.

Fixes https://github.com/flutter/flutter/issues/112221

Pre-launch Checklist

  • [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the [CLA].
  • [ ] All existing and new tests are passing.

a-wallen avatar Oct 08 '22 00:10 a-wallen

Gold has detected about 2 new digest(s) on patchset 2. View them at https://flutter-engine-gold.skia.org/cl/github/36673

skia-gold avatar Oct 08 '22 01:10 skia-gold

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Oct 26 '22 23:10 flutter-dashboard[bot]

This PR should be test exempt now that it only removes code.

a-wallen avatar Oct 28 '22 18:10 a-wallen