engine icon indicating copy to clipboard operation
engine copied to clipboard

[canvaskit] Make the context current before disposing it

Open harryterkelsen opened this issue 3 years ago • 0 comments

When we delete a Surface context (for example because it has resized) we must make sure that it is the current context or Skia might throw an exception while deleting resources associated with that context.

Fixes https://github.com/flutter/flutter/issues/91881

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

harryterkelsen avatar Oct 07 '22 23:10 harryterkelsen