engine icon indicating copy to clipboard operation
engine copied to clipboard

[Display Lists] Create DlComposeColorFilter

Open JsouLiang opened this issue 3 years ago • 4 comments

For this issue: https://github.com/flutter/flutter/issues/109843

JsouLiang avatar Aug 22 '22 10:08 JsouLiang

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Aug 22 '22 10:08 flutter-dashboard[bot]

From PR triage: @JsouLiang are you interested in continuing with this PR?

zanderso avatar Sep 08 '22 20:09 zanderso

From PR triage: @JsouLiang are you interested in continuing with this PR?

The work that needed this is on hold while we investigate some properties of combining multiple effects and rendering attributes in saveLayers. If we decide that combining color filters is not going to be fruitful based on those investigations then we might not need this. Perhaps demote it to a draft?

(And if Flutter ever exposes composed ColorFilters at the framework level as we've done with ImageFilters, then we'd need this, but so far this is only a speculative need for pending work.)

flar avatar Sep 08 '22 21:09 flar

From PR review triage: Changing to WIP/Draft as suggested.

zanderso avatar Sep 29 '22 20:09 zanderso

@JsouLiang is this PR still on your radar?

Hixie avatar Jan 17 '23 23:01 Hixie

We might need this for InvertColors but we aren't sure it needs to go through this interface.

chinmaygarde avatar Feb 16 '23 21:02 chinmaygarde