engine icon indicating copy to clipboard operation
engine copied to clipboard
verified publisher icon flutter

Instrument Image and Picture for leak tracking.

Open polina-c opened this issue 3 years ago • 3 comments

See go/dart-leaktracker-productization.

Before merging to https://github.com/flutter/engine/tree/main/lib:

  • [x] code in ui
  • [x] code in web_ui
  • [x] test coverage
  • [ ] prepare PR with MemoryAllocations in flutter/foundation.dart, to submit it as soon as this change is available for Flutter Framework, so that the references in documentation refer to a real thing.

polina-c avatar Aug 09 '22 18:08 polina-c

@yjbanov , can you advise, please - is it right understanding that I need to add instrumentation both in lib/ui and in lib/web_ui?

polina-c avatar Aug 09 '22 18:08 polina-c

@yjbanov , can you advise, please - is it right understanding that I need to add instrumentation both in lib/ui and in lib/web_ui?

The API should be identical, but if leak tracking a VM-only feature that doesn't have an equivalent in dart2js/DDC, then the web version can remain a noop.

yjbanov avatar Aug 09 '22 18:08 yjbanov

Gold has detected about 37 new digest(s) on patchset 21. View them at https://flutter-engine-gold.skia.org/cl/github/35274

skia-gold avatar Aug 11 '22 23:08 skia-gold