engine icon indicating copy to clipboard operation
engine copied to clipboard

Using additional information to have a better partial repaint performance.

Open endless7 opened this issue 3 years ago • 3 comments

design doc: https://docs.google.com/document/d/11ayzXfN1gQgZPVJUNr8n9hqU_7GKA55dUhtF_cuiLUY/edit#

endless7 avatar Aug 02 '22 12:08 endless7

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Aug 02 '22 12:08 flutter-dashboard[bot]

From PR triage: Adding some reviewers, but it looks like there might still be feedback to address on the design doc?

zanderso avatar Aug 04 '22 20:08 zanderso

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

flutter-dashboard[bot] avatar Sep 13 '22 09:09 flutter-dashboard[bot]

@endless7 Is this PR (and design doc) still on your radar?

Hixie avatar Dec 07 '22 00:12 Hixie

Is this PR (and design doc) still on your radar

Yes, it's currently under our application testing for data.

endless7 avatar Dec 07 '22 07:12 endless7

From PR triage: There are open questions in the design doc and the consensus is that we aren't going to ahead with this.

chinmaygarde avatar Feb 16 '23 21:02 chinmaygarde