engine icon indicating copy to clipboard operation
engine copied to clipboard

WIP: [windows] Add PlatformView support for Win32

Open eggfly opened this issue 3 years ago • 4 comments

Implements:

  • https://github.com/flutter/flutter/issues/31713

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [ ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I signed the CLA.
  • [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

eggfly avatar Apr 22 '22 04:04 eggfly

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Apr 22 '22 04:04 flutter-dashboard[bot]

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

flutter-dashboard[bot] avatar May 12 '22 04:05 flutter-dashboard[bot]

any one take care of this?

wanjm avatar Jul 15 '22 01:07 wanjm

or any plan for platformview in flutter, it seems it last a long time

wanjm avatar Jul 15 '22 01:07 wanjm

Since this patch has been WIP with no changes since April, and doesn't look ready for review (lots of commented out code/debug logging) I'm going to close this for now. If you do have a more recent/complete implementation please open a new PR and add reviewers when ready.

For others inquiring about PlatformView support on desktop. PlatformView support for the macOS embedder is getting close, Windows support is something that @loic-sharma will be working on soon.

cbracken avatar Oct 04 '22 23:10 cbracken