form_builder_validators icon indicating copy to clipboard operation
form_builder_validators copied to clipboard

Upgrade intl to 0.19.0 AND gradle from 4.2.2 to 7.4.2

Open jhaglund opened this issue 1 year ago • 5 comments

Connection with issue(s)

Close #90
Close #91 Close #92 Close #93

Connected to #???

Solution description

(updated May 17 to try to be more clear) You're welcome to replicate the steps I did. The only "manual" edit I did was to change the 18 to 19, otherwise the changes were all made by the Android Studio tools.

The key is instead of opening the Flutter project, you open the /example/android directory with Android Studio then use the AGP upgrade assistant (under tools) to upgrade gradle. Maybe VS code can do it but IDK. Sorry I made so many commits, this process gets sticky so I was cribbing my progress.

Thanks!

Screenshots or Videos

To Do

  • [x] Read contributing guide
  • [x] Check the original issue to confirm it is fully satisfied
  • [x] Add solution description to help guide reviewers
  • [ ] Add unit test to verify new or fixed behaviour
  • [ ] If apply, add documentation to code properties and package readme

jhaglund avatar May 17 '24 06:05 jhaglund

Also need update the minimum flutter and dart version to avoid conflicts with old versions

environment:
  sdk: ^3.4.0
  flutter: ">=3.22.0"

deandreamatias avatar May 17 '24 10:05 deandreamatias

@deandreamatias When can it be merged, please?

samuelyung avatar May 18 '24 15:05 samuelyung

When will this be merged?

enchance avatar May 18 '24 18:05 enchance

pls merge

listepo avatar May 18 '24 20:05 listepo

any idea when this will merge?

ozayr avatar May 19 '24 09:05 ozayr

https://github.com/flutter-form-builder-ecosystem/form_builder_validators/pull/88 this pr should also be included in this major update to the dependencies

martijn00 avatar May 19 '24 16:05 martijn00

Sorry, I don't have time to check build errors but I also don't want to get the MR approved without the build working properly. If someone can solve it, I will approve it on the same day.

deandreamatias avatar May 19 '24 20:05 deandreamatias

I'll be honest, the various Java environment and tool versions confuse me.

The error says to run flutter doctor --version to find the Java version. Mine returns Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874) but IDK how to check what the build server is using.

It provides this link to explain java and gradle compatibility: https://docs.gradle.org/current/userguide/compatibility.html#java But to me, it is unclear what Java versions the even numbered gradle versions are compatible with (who is reverse compatible with who?).

Anyway, I ran the AGP upgrade again, bringing the Gradle plugin to the latest, 8.3.1 (but also, it says 8.4 in places), and it still builds for me. I didn't upgrade to the latest before because 7.4 was where I got it to build on my machine.

I hope this helps!

jhaglund avatar May 19 '24 22:05 jhaglund

@jhaglund I'll get to this soon and update my PR to fix the build system and dependencies.

martijn00 avatar May 19 '24 23:05 martijn00

Olee it's solved! Thanks a lot for all to accomplish this

deandreamatias avatar May 20 '24 18:05 deandreamatias

@deandreamatias When will publish a release to pub?

samuelyung avatar May 20 '24 22:05 samuelyung

@deandreamatias When will publish a release to pub?

Everyone can do the PR for release (like this). After that, I'm only add the tag to repo and automatically is updated to pub.dev

deandreamatias avatar May 21 '24 06:05 deandreamatias

I'll update my PR today and will set everything ready. It's better to do it all in the 1 major update.

martijn00 avatar May 21 '24 06:05 martijn00

@samuelyung @deandreamatias my PR is updated now.

martijn00 avatar May 21 '24 11:05 martijn00

Is this build updated on pub dev ? I am getting same error after upgrading to 9.1.0 I have upgraded flutter version also.

WasimMemon avatar May 21 '24 15:05 WasimMemon

No, my PR is not merged yet and there is no new tag set on the repo.

martijn00 avatar May 21 '24 15:05 martijn00

Is this build updated on pub dev ? I am getting same error after upgrading to 9.1.0 I have upgraded flutter version also.

As a temporary workaround, you can edit your pubspec.yaml to point to the github instead of pub.dev

#form_builder_validators: ^9.0.0
  form_builder_validators:
    git:
      url: https://github.com/flutter-form-builder-ecosystem/form_builder_validators.git
      ref: main # branch name


jhaglund avatar May 21 '24 18:05 jhaglund

I'm waiting impatiently for the fix to be deployed, and I'd be very grateful to you because it's holding me back quite a bit in my project. Thank you for your responsiveness, it's great!

Jsuisenlocation avatar May 22 '24 10:05 Jsuisenlocation

I don't understand why this kind of critical hotfix needs to wait to publish. This package simply is unusable without this fix. No, the reality is that any project which depends on this package instantly becomes unbuildable. This fix should be publish to pub ASAP IMO.

samuelyung avatar May 22 '24 11:05 samuelyung

I don't understand why this kind of critical hotfix needs to wait to publish. This package simply is unusable without this fix. No, the reality is that any project which depends on this package instantly becomes unbuildable. This fix should be publish to pub ASAP IMO.

Because this is a open source package and I work for free in this project. I need spent my time in my main job to pay my bills. Neither Google, Flutter nor any other company pays me to work on this.

I am open and encourage anyone to participate in the flutter-form-builder-ecosystem

deandreamatias avatar May 22 '24 15:05 deandreamatias

Version 10.0.0 with fix, deployed https://pub.dev/packages/form_builder_validators

deandreamatias avatar May 22 '24 15:05 deandreamatias

I don't understand why this kind of critical hotfix needs to wait to publish. This package simply is unusable without this fix. No, the reality is that any project which depends on this package instantly becomes unbuildable. This fix should be publish to pub ASAP IMO.

Because this is a open source package and I work for free in this project. I need spent my time in my main job to pay my bills. Neither Google, Flutter nor any other company pays me to work on this.

I am open and encourage anyone to participate in the flutter-form-builder-ecosystem

And I and many others are extremely grateful to you, don't take it to heart when people talk to you as if you owe them your job, there are some awkward people like that, thank you for the fix.

Jsuisenlocation avatar May 22 '24 16:05 Jsuisenlocation