fluentassertions icon indicating copy to clipboard operation
fluentassertions copied to clipboard

Make license change more clear

Open burnchar opened this issue 1 year ago • 1 comments

Description

Congratulations on getting some compensation after years of serving the community essentially for free. I get it. The new license allows you and Xceed to get a share from for-profit companies that use your work. (The work of contributers is outside the scope of this bug report).

However, the very significant change is unclear. The change needs clear notice in plain language that FluentAssertions usage is now very different from most NuGet packages, and different from its past. Something like: "NOTICE: FluentAssertions is no longer free for commercial use, and is no longer under the Apache 2.0 license." It needs a direct link to the new license.

For example, the first bullet in the release notes is:

  • Update ownership and license - #2943 That link doesn't point to a license, and explains nothing without each reader digging in.

The main web page (fluentassertions.com) does casually mention the Xceed partnership, but little about it. The "Learn more" link does not help users learn more -- it just points them to the Xceed corporate web page.

Reproduction Steps

// Arrange
string input = "MyString";

// Act
char result = input[0];

// Assert
result.Should().Be('M');

Expected behavior

Honest, clear language about the change with direct links to actual information.

Actual behavior

Hidden, casual, borderline misleading language.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Are you willing to help with a pull-request?

No

burnchar avatar Jan 15 '25 19:01 burnchar

The new license allows you and Xceed to get a share from for-profit companies that use your work. Would be nice to also clarify the how this applied to not-for-profit/non-profit entities.

ms6073 avatar Jan 15 '25 21:01 ms6073

Good suggestions. We'll update them.

dennisdoomen avatar Jan 16 '25 21:01 dennisdoomen

"NOTICE: FluentAssertions is no longer free for commercial use, and is no longer under the Apache 2.0 license."

This would be a blatant lie. All work done prior to the license change is in fact licensed under Apache 2.0. This essentially affects everything done so far since there is not a single commit contributing any code under the new license. The old code will remain under Apache 2.0 forever. You cannot retroactively change a license on existing code.

klemmchr avatar Jan 19 '25 00:01 klemmchr