[WIP] feat: add multiline parser support for fluentbit
What this PR does / why we need it:
currently users cannot setup custom multiline parser via operator. and there're many unsupported fields for multiline parser in filter
Which issue(s) this PR fixes:
Fixes #176 and #336
- add more fields for multiline parser in filter (#176)
- add ClusterMultilineParser and MultilineParser crd for multiline parser (#336)
Does this PR introduced a user-facing change?
feat: add multiline parser support for fluentbit
Additional documentation, usage docs, etc.:
@ksdpmx Hi Jason, would you resolve the conflicts and conversation remains?
@ksdpmx Hi Jason, would you resolve the conflicts and conversation remains?
@benjaminhuo ~sure will check this weekend.~ sorry for the late reply. quite busy recently:(
@ksdpmx looking forward multiline feature, could you please find time to resolve conflicts.
@ksdpmx Do you have any updates when you will have time to resolve these conflicts, this is a feature I would be very interested also. Thanks.
~thanks for the patience and understanding.. I've had some free time this month. continuing the remaining work..~ :(
Hi, @ksdpmx do you need any help with this task? We really need this feature and we would like help you resolving it.
Hi, @ksdpmx! Also interested in this feature. How can I help you?
Hi everybody! @ksdpmx, would you be so kind to review and accept PR to your repo https://github.com/ksdpmx/fluent-operator/pull/1 with fixes:
- Adjusted multilineparserSelector to multilineParserSelector as of comment @benjaminhuo
- Added watches for ClusterMultilineParser and MultilineParser
- Fixed inline import in MultilineParserSpec
- Rebased to fluent:master Checked with our team - it works. If something need to be fixed, please let me know.
Hi everybody! @ksdpmx, would you be so kind to review and accept PR to your repo ksdpmx#1 with fixes:
- Adjusted multilineparserSelector to multilineParserSelector as of comment @benjaminhuo
- Added watches for ClusterMultilineParser and MultilineParser
- Fixed inline import in MultilineParserSpec
- Rebased to fluent:master Checked with our team - it works. If something need to be fixed, please let me know.
I think you can resubmit a pull request to this repository. There are too many commits here, which makes it a bit confusing. After reviewing the code, I noticed that you are treating 'multiline' as a resource to watch, and I don't think it's the best approach in this regard (it could be my misunderstanding). I suggest you submit a pull request so that we can discuss and explore alternative solutions together."
@ksdpmx are you able to look at this? :)
some internal team is also interested in this feature.. allow me few hours to catch with the context this time..
I think you can resubmit a pull request to this repository. There are too many commits here, which makes it a bit confusing.
- two commits w/o sign-off
- two rebases which makes it hard to squash
- too many commits for this legacy PR
so here's the new one https://github.com/fluent/fluent-operator/pull/1100. @esperoz please submit another new one if there's any concern about this PR. i'm fine with the ownership of it :)
Finished in https://github.com/fluent/fluent-operator/pull/1100, close this for now