fluent-operator icon indicating copy to clipboard operation
fluent-operator copied to clipboard

[WIP] feat: add multiline parser support for fluentbit

Open ksdpmx opened this issue 2 years ago • 9 comments

What this PR does / why we need it:

currently users cannot setup custom multiline parser via operator. and there're many unsupported fields for multiline parser in filter

Which issue(s) this PR fixes:

Fixes #176 and #336

  1. add more fields for multiline parser in filter (#176)
  2. add ClusterMultilineParser and MultilineParser crd for multiline parser (#336)

Does this PR introduced a user-facing change?

feat: add multiline parser support for fluentbit

Additional documentation, usage docs, etc.:


ksdpmx avatar Jul 23 '23 12:07 ksdpmx

@ksdpmx Hi Jason, would you resolve the conflicts and conversation remains?

benjaminhuo avatar Aug 28 '23 01:08 benjaminhuo

@ksdpmx Hi Jason, would you resolve the conflicts and conversation remains?

@benjaminhuo ~sure will check this weekend.~ sorry for the late reply. quite busy recently:(

ksdpmx avatar Aug 28 '23 03:08 ksdpmx

@ksdpmx looking forward multiline feature, could you please find time to resolve conflicts.

americans007 avatar Sep 06 '23 07:09 americans007

@ksdpmx Do you have any updates when you will have time to resolve these conflicts, this is a feature I would be very interested also. Thanks.

JoeDerby avatar Dec 07 '23 12:12 JoeDerby

~thanks for the patience and understanding.. I've had some free time this month. continuing the remaining work..~ :(

ksdpmx avatar Dec 09 '23 03:12 ksdpmx

Hi, @ksdpmx do you need any help with this task? We really need this feature and we would like help you resolving it.

pikodd avatar Dec 19 '23 10:12 pikodd

Hi, @ksdpmx! Also interested in this feature. How can I help you?

esperoz avatar Jan 09 '24 10:01 esperoz

Hi everybody! @ksdpmx, would you be so kind to review and accept PR to your repo https://github.com/ksdpmx/fluent-operator/pull/1 with fixes:

  • Adjusted multilineparserSelector to multilineParserSelector as of comment @benjaminhuo
  • Added watches for ClusterMultilineParser and MultilineParser
  • Fixed inline import in MultilineParserSpec
  • Rebased to fluent:master Checked with our team - it works. If something need to be fixed, please let me know.

esperoz avatar Jan 12 '24 10:01 esperoz

Hi everybody! @ksdpmx, would you be so kind to review and accept PR to your repo ksdpmx#1 with fixes:

  • Adjusted multilineparserSelector to multilineParserSelector as of comment @benjaminhuo
  • Added watches for ClusterMultilineParser and MultilineParser
  • Fixed inline import in MultilineParserSpec
  • Rebased to fluent:master Checked with our team - it works. If something need to be fixed, please let me know.

I think you can resubmit a pull request to this repository. There are too many commits here, which makes it a bit confusing. After reviewing the code, I noticed that you are treating 'multiline' as a resource to watch, and I don't think it's the best approach in this regard (it could be my misunderstanding). I suggest you submit a pull request so that we can discuss and explore alternative solutions together."

wenchajun avatar Jan 16 '24 08:01 wenchajun

@ksdpmx are you able to look at this? :)

elsnepal avatar Mar 28 '24 10:03 elsnepal

some internal team is also interested in this feature.. allow me few hours to catch with the context this time..

ksdpmx avatar Mar 30 '24 03:03 ksdpmx

I think you can resubmit a pull request to this repository. There are too many commits here, which makes it a bit confusing.

  • two commits w/o sign-off
  • two rebases which makes it hard to squash
  • too many commits for this legacy PR

so here's the new one https://github.com/fluent/fluent-operator/pull/1100. @esperoz please submit another new one if there's any concern about this PR. i'm fine with the ownership of it :)

ksdpmx avatar Mar 30 '24 07:03 ksdpmx

Finished in https://github.com/fluent/fluent-operator/pull/1100, close this for now

benjaminhuo avatar Apr 06 '24 14:04 benjaminhuo