fluent-logger-java icon indicating copy to clipboard operation
fluent-logger-java copied to clipboard

prohibit fluent logger to chocke on its own log messages in case of failure

Open danischroeter opened this issue 9 years ago • 3 comments

if the fluent logger is used as a logger for slf4j and it fails to send messages it will choke on its own failure messages (cannot send message) once the connection to fluentd is broken ->this change breaks this circle by only logging the failure to send messages max once per minute

danischroeter avatar Aug 10 '16 06:08 danischroeter

@danischroeter https://github.com/fluent/fluent-logger-java/commit/afc9e84e0210cd106124a4904c6a2eb140d036b3 mitigates the issue?

komamitsu avatar Aug 13 '16 07:08 komamitsu

@komamitsu sorry was off... nope the referenced commit only reduces the problem to the case when reconnect is enabled. For reconnect the problem stays the same. If you agree I resolve the merge conflict so you could merge.

danischroeter avatar Sep 21 '16 13:09 danischroeter

I see. Can I ask you to resolve the merge conflict and address this comment https://github.com/fluent/fluent-logger-java/pull/59/files#r80361139 ? Thanks

komamitsu avatar Sep 24 '16 13:09 komamitsu