fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

in_node_exporter_metrics: fix size of core_throttles_set

Open faran1512 opened this issue 1 year ago • 0 comments

…nux.c

The issue is in ne_cpu_linux.c In core_throttles_set[n][m], n has size 32 only. On my PC, I have 44 cores and physical_package_id can have max value of 88.

On line 140 we see: if (core_throttles_set[physical_package_id][core_id] != 0)

This accesses array at index 88, that has size of only 32. This causes a segmentation fault. Because we access data from invalid address outside the range of buffer.

Fix: The size is changed to 256 to accomodate high core count.

Signed-off-by: Faran Abdullah [email protected]


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

faran1512 avatar Oct 09 '24 08:10 faran1512