fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

in_process_exporter_metrics: convert rss memory from pages to bytes

Open Bedledl opened this issue 1 year ago • 3 comments

https://github.com/fluent/fluent-bit/issues/9343

Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [x] Example configuration file for the change
  • [x] Debug log output from testing the change
  • [ ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [ ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Bedledl avatar Sep 04 '24 11:09 Bedledl

Example configuration: fluent-bit -i process_exporter_metrics -p metrics="memory" -o stdout

Output thats shows successful fix: process_memory_bytes{name="rsyslogd",pid="167",ppid="1",type="rss"} = 483328

cat /proc/167/status | grep Rss RssAnon: 472 kB RssFile: 0 kB RssShmem: 0 kB

Bedledl avatar Sep 04 '24 11:09 Bedledl

Could you use signed-off in your commit? We use DCO and it complains signed-off is missing:

Summary

Commit sha: 09989e7, Author: Bettina Riedl, Committer: Bettina Riedl; The sign-off is missing.

cosmo0920 avatar Sep 25 '24 22:09 cosmo0920

Could you use signed-off in your commit? We use DCO and it complains signed-off is missing:

Summary

Commit sha: 09989e7, Author: Bettina Riedl, Committer: Bettina Riedl; The sign-off is missing.

Added sign-off :)

Bedledl avatar Oct 14 '24 13:10 Bedledl

Force push was rebase on current main

Bedledl avatar Jan 09 '25 15:01 Bedledl

Hi all, any chance to get this fix merged?

pawelrubin avatar Nov 10 '25 13:11 pawelrubin