fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

Amazon S3: Mismatch when reading HTTP header from GCS

Open gouyelliot opened this issue 1 year ago • 3 comments

This commit includes the HTTP separator when looking for the header values in the response payload, to avoid mismatching header ending with the same name. See the linked issue for more info and example.

Fixes #8790


Testing Before we can approve your change; please submit the following in a comment:

  • [ ] Example configuration file for the change
  • [ ] Debug log output from testing the change
  • [ ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ ] Run local packaging test showing all targets (including any new ones) build.
  • [ ] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ ] Documentation required for this feature

Backporting

  • [ ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

gouyelliot avatar May 03 '24 10:05 gouyelliot

Hey @PettitWesley, can we get this PR reviewed and merged? Currently, there is no GCS Output Plugin but this fix could help as a workaround to upload to GCS bucket meanwhile.

vg-meesho avatar Oct 15 '24 11:10 vg-meesho

@PettitWesley @sparrc @singholt @swapneils

Bumping up for review

vg-meesho avatar Aug 24 '25 09:08 vg-meesho