fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

engine: adjust miniz include

Open bgaifullin opened this issue 2 years ago • 8 comments

Miniz is usually installed without prefixes and is unbundled this way


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [ ] Example configuration file for the change
  • [ ] Debug log output from testing the change
  • [ ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ ] Run local packaging test showing all targets (including any new ones) build.
  • [x] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ ] Documentation required for this feature

Backporting

  • [ ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

bgaifullin avatar Sep 01 '23 15:09 bgaifullin

seems like tests flapped, because this change may affect only compilation.

bgaifullin avatar Sep 02 '23 08:09 bgaifullin

The macOS tests are flaky yeah so this looks fine - I triggered a complete build for all supported targets to confirm it is ok for all variants of the supported compilation targets.

patrick-stephens avatar Sep 02 '23 12:09 patrick-stephens

Builds are successful.

bgaifullin avatar Sep 04 '23 10:09 bgaifullin

@patrick-stephens, please check, seems like failing builds are flap.

bgaifullin avatar Nov 24 '23 10:11 bgaifullin

@patrick-stephens, please check, seems like failing builds are flap.

See: https://github.com/fluent/fluent-bit/pull/7890#issuecomment-1703822007 As far as I can see the only failures are those.

patrick-stephens avatar Nov 24 '23 12:11 patrick-stephens

And, how to merge this PR?

bgaifullin avatar Nov 24 '23 14:11 bgaifullin

It needs a codeowner review to merge so is in the queue for @leonardo-albertovich and others to handle.

patrick-stephens avatar Nov 24 '23 15:11 patrick-stephens

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Feb 23 '24 01:02 github-actions[bot]