fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard
verified publisher icon fluent

fix various object destroy calls (wrong/missing)

Open MrTomasz opened this issue 3 years ago • 4 comments

This provides various fixes for incorrect/missing object destroy calls in various places during investigation of issue #6748 .

Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

MrTomasz avatar Feb 03 '23 02:02 MrTomasz

Commit message checker could be more useful if it could say which commit is not compliant with the requirements.

MrTomasz avatar Feb 05 '23 00:02 MrTomasz

Could somebody look into that?

MrTomasz avatar Feb 10 '23 00:02 MrTomasz

Hi @MrTomasz, the name of the check is misleading. Your commit messages are fine, but the PR title is also checked (see documentation of the used action: https://github.com/GsActions/commit-message-checker/blob/4c06ad2446942246543ef9c50f672a58782bf7b0/README.md?plain=1#L8) and it's failing because there is no prefix.

Garfield96 avatar Apr 18 '23 21:04 Garfield96

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jul 19 '23 02:07 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 27 '24 02:11 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 28 '25 02:08 github-actions[bot]