fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

dockerfiles: includes AWS root CA in Windows Dockerfile

Open pmcenery opened this issue 3 years ago • 4 comments

Install Amazon Root CA cert into runtime image. Fixes #6498


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [ N/A ] Example configuration file for the change
  • [ N/A ] Debug log output from testing the change
  • [ N/A ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ N/A ] Attached local packaging test output showing all targets (including any new ones) build.

Documentation

  • [ N/A ] Documentation required for this feature

Backporting

  • [ N/A ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

pmcenery avatar Dec 05 '22 13:12 pmcenery

@pmcenery can you sort the DCO check out and update the commits to start with dockerfiles: ? The change looks fine but we'll have to rerun the CI once you update anyway and it takes a while so I'd rather not waste the resources.

https://github.com/fluent/fluent-bit/pull/6499/checks?check_run_id=9890497706

DCO There is one commit incorrectly signed off. This means that the author of this commit failed to include a Signed-off-by line in the commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name [email protected] in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.

Rebase the branch If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

You are the only author of the commits in this branch You are absolutely certain nobody else is doing any work based upon this branch There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty) To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line. In your local branch, run: git rebase HEAD~1 --signoff Force push your changes to overwrite the branch: git push --force-with-lease origin paulm

patrick-stephens avatar Dec 05 '22 14:12 patrick-stephens

The AWS Distro has windows support FYI: https://aws.amazon.com/about-aws/whats-new/2022/11/aws-centralized-logging-windows-containers-amazon-ecs-eks/

PettitWesley avatar Dec 05 '22 23:12 PettitWesley

@pmcenery please resolve the linting failure - either ignore with justification or correct.

patrick-stephens avatar Jan 31 '23 13:01 patrick-stephens

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar May 02 '23 01:05 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 27 '24 02:11 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 28 '25 02:08 github-actions[bot]